Nodes: Fix recursion with environment nodes. #30277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #30255.
Description
This fixes the recursion issue when using
NormalMapNode
withEnvironmentNode
.The root cause is that
EnvironmentNode
modifies the builder's context with a customgetUV()
which relies ontransformedNormalView
. Using this TSL object triggerssetupNormal()
which consequently triggers the build ofNormalMapNode
which now uses an invalidgetUV()
implementation.@sunag Granted this is a bit of an edge case but this kind of context behavior might be unexpected in other scenarios as well. It would be great to limit the scope of
context()
somehow so code like inNormalMapNode
wouldn't be necessary.