New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSL: display atan second argument in the docs #30287

Merged

Mugen87 merged 1 commit into mrdoob:dev from s-rigaud:atan2-fix-doc

Jan 8, 2025

Contributor

s-rigaud commented Jan 8, 2025

Related issue: #30131

Description

With the new code, atan can be called with two arguments. If so, it is translated to atan for GLSL and atan2 for WGSL https://github.com/sunag/three.js/blob/18046a6e4f79fb38bb98f14e12fa0e0268023c05/src/nodes/math/MathNode.js#L236


          TSL: display atan second argument

a1cc829

github-actions bot commented Jan 8, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	339.51 79.09	339.51 79.09	+0 B +0 B
WebGPU	490.94 136.34	490.94 136.34	+0 B +0 B
WebGPU Nodes	490.41 136.22	490.41 136.22	+0 B +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.35 112.14	465.35 112.14	+0 B +0 B
WebGPU	560.24 151.74	560.24 151.74	+0 B +0 B
WebGPU Nodes	516.33 141.53	516.33 141.53	+0 B +0 B

s-rigaud changed the title ~~TSL: display atan second argument~~ TSL: display atan second argument in the docs

Mugen87 added this to the r173 milestone

Mugen87 approved these changes

View reviewed changes

Mugen87 merged commit 8f31ce2 into mrdoob:dev

12 checks passed

s-rigaud deleted the atan2-fix-doc branch

January 22, 2025 17:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet