Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renderer: fix types and references #30318

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Renderer: fix types and references #30318

merged 1 commit into from
Jan 13, 2025

Conversation

s-rigaud
Copy link
Contributor

Description

While trying different TS configs to improve the project I found the following errors.

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.52
79.1		 339.52
79.1		 +0 B
+0 B
WebGPU 490.81
136.38		 490.85
136.4		 +42 B
+13 B
WebGPU Nodes 490.27
136.28		 490.32
136.29		 +42 B
+13 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.41
112.15		 465.41
112.15		 +0 B
+0 B
WebGPU 561.38
152.09		 561.43
152.1		 +42 B
+8 B
WebGPU Nodes 516.77
141.66		 516.81
141.67		 +42 B
+8 B

@Mugen87 Mugen87 added this to the r173 milestone Jan 13, 2025
@Mugen87 Mugen87 merged commit 47cbf9d into mrdoob:dev Jan 13, 2025
12 checks passed
@s-rigaud s-rigaud deleted the Renderer-fix-types-and-references branch January 22, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r173
Development

Successfully merging this pull request may close these issues.
2 participants
@s-rigaud @Mugen87