WebXRManager: Safely check for XRWebGLBinding
.
#30319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the immersive-web-emulator XRWebGLBinding is undefined. The current code:
throws an error because it directly references XRWebGLBinding without checking if it is defined. I'm unsure whether all WebXR devices use XRWebGLBinding or if a PR would be better suited for their repo. This is a simple fix which resolves the issue when testing any of the WebXR demos using popular emulators.