Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMREMGenerator: Don't pollute node material scope. #30324

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 14, 2025

Related issue: -

Description

This PR introduces a new Weak Map in renderers/common/extras/PMREMGenerator.js to make sure the module does not store a uniforms dictionary in the object scope of node materials.

It also fixes the names of two module scope variables which should begin with a _.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.53
79.09
339.53
79.09
+0 B
+0 B
WebGPU 491.01
136.43
491.02
136.44
+13 B
+13 B
WebGPU Nodes 490.47
136.32
490.49
136.34
+13 B
+10 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.42
112.15
465.42
112.15
+0 B
+0 B
WebGPU 561.58
152.14
561.59
152.13
+13 B
-5 B
WebGPU Nodes 516.97
141.71
516.98
141.7
+13 B
-8 B

@Mugen87 Mugen87 added this to the r173 milestone Jan 15, 2025
@Mugen87 Mugen87 merged commit d293a0f into mrdoob:dev Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant