26665: Toolbar buttons do not react to long clicks #26679
+23
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26665
This is the same issue as #16012. The fix done there appears not to have fixed it. Handling the
pressAndHold
signal, even directly as implemented in the fix, suppresses theclick
signal.I have found a new fix: when handling the
pressAndHold
signal, if we do not consume it, we should set theaccepted
property of the mouse event tofalse
. In this case theclick
event will not be suppressed. Interestingly, forpressAndHold
theaccepted
property istrue
by default which means the event has to be unaccepted if not consumed. So I am reverting the fix for #16012 and am taking care of theaccepted
property: inFlatButton
I setaccepted
tofalse
to not suppress theclick
signal if there are no handlers or none consumes the event. On the other hand, whenpressAndHold
is consumed inNoteInputBar
andStyledToolBarItem
,accepted
will be set totrue
.