fix(core): Unload any existing version of a community nodes package b…

…efore upgrading it (#11727)
n8n-io · Nov 19, 2024 · 1d8fd13 · 1d8fd13
1 parent 17ef2c6
commit 1d8fd13
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/packages/cli/src/services/__tests__/community-packages.service.test.ts b/packages/cli/src/services/__tests__/community-packages.service.test.ts
@@ -410,6 +410,12 @@ describe('CommunityPackagesService', () => {
 				expect.any(Object),
 				expect.any(Function),
 			);
+			expect(loadNodesAndCredentials.unloadPackage).toHaveBeenCalledWith(
+				installedPackage.packageName,
+			);
+			expect(loadNodesAndCredentials.loadPackage).toHaveBeenCalledWith(
+				installedPackage.packageName,
+			);
 		});
 
 		test('should throw when not licensed', async () => {

diff --git a/packages/cli/src/services/community-packages.service.ts b/packages/cli/src/services/community-packages.service.ts
@@ -354,6 +354,7 @@ export class CommunityPackagesService {
 
 		let loader: PackageDirectoryLoader;
 		try {
+			await this.loadNodesAndCredentials.unloadPackage(packageName);
 			loader = await this.loadNodesAndCredentials.loadPackage(packageName);
 		} catch (error) {
 			// Remove this package since loading it failed