Split dev dependencies into separate modules #1788
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
split-dev-dependencies
branch
from
7a7ba0c to
d00aaba
Compare
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
split-dev-dependencies
branch
from
d00aaba to
3428b6e
Compare
wallyqs
reviewed
Feb 12, 2025
| github.com/nats-io/nkeys v0.4.9 | ||
| github.com/nats-io/nuid v1.0.1 | ||
| golang.org/x/text v0.21.0 | ||
| google.golang.org/protobuf v1.36.2 |
There was a problem hiding this comment.
would this one be needed if we put a go.mod under encoders?
There was a problem hiding this comment.
Not really under encoders - enc.go imports encoders/builtin, so even if we put it in a separate module, it would have to be added to root go.mod (with protobuf as an indirect dependency), so does not make sense.
We could in theory make encoders/protobuf a separate module but then we'd have to release and version it separately, not sure it's a good solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski [email protected]