Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents KV ListKeysFiltered from returning deleted keys #1803

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Prevents KV ListKeysFiltered from returning deleted keys #1803

merged 4 commits into from
Feb 14, 2025

Conversation

kruegernet
Copy link
Contributor

piotrpio
piotrpio reviewed Feb 14, 2025
View reviewed changes
@kruegernet kruegernet requested a review from piotrpio February 14, 2025 14:47
@kruegernet
Copy link
Contributor Author

sorry @piotrpio , I should have run test first: didn't see that we cannot re-use our supplied filter. Should be working as expected now :)

@coveralls
Copy link

Coverage Status

coverage: 84.833% (-0.02%) from 84.852%
when pulling 3bf5c31 on kruegernet:kv-listkeysfiltered-no-deleted
into 901c987 on nats-io:main.

piotrpio
piotrpio approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit 7885c8c into nats-io:main Feb 14, 2025
4 checks passed
@piotrpio piotrpio mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kruegernet @coveralls @piotrpio