[ADDED] ReconnectErrCB + handler function #1804
Open
+56
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am often using those connect options due to an offline first approach:
I noticed that none of the current handlers covers handling connection attempt errors when there never was an initial connection with those options.
This is probably a very narrow use case.
That is why I thought adding
ReconnectErrCB
and the correspondingReconnectErrHandler
makes sense.Since this is my first contribution, please let me know whether I missed something or whether it should be solved
in a complete different manner. I am willing to put in more work if necessary of course.
Sorry for having a bit of additional diffs due to using
gopls
formatting. I did not find any formatting rules.If there are any, I am happy to reformat accordingly.
Regards