feat: Improve error messages for invalid submissions

[Koc]

Right now it is really hard to understand for end users why form can't be submitted. This PR aims to improve validation messages.

[codecov]

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 43.43%. Comparing base (19feceb) to head (ccc9c19).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2533   +/-   ##
=========================================
  Coverage     43.43%   43.43%           
- Complexity      882      885    +3     
=========================================
  Files            77       77           
  Lines          3361     3361           
=========================================
  Hits           1460     1460           
  Misses         1901     1901           

[Chartman123]

Nice one :)

[susnux]

I dont think this makes sense, what is the use case?
It is nothing shown to end users, that should already be done in the frontend and if it is not then there is a bug in the frontend that should be fixed.

So this is for developers that use the API?
In this case we should refactor the function at all (validateSubmission) to be void and throw instead on error.
Either InvalidArgumentException if we keep this developers only I would prefer this.
Otherwise an \OCP\HintException which would allow translated error messages for frontend - but here again we should never allow to submit something invalid so a frontend validation is wrong.

[Koc]

@susnux yeah, it's mostly for API usage. I've refactored method to throw an InvalidArgumentException as you suggested.

Psalm failures looks unrelated