Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide runtimeConfig to getImage function (#1247) #1428

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

cjpearson
Copy link
Contributor

@cjpearson cjpearson commented Aug 15, 2024

πŸ”— Linked issue

resolves #1247

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change passes the runtime config to the getImage function of an image provider. It allows built-in or custom providers to support options that are configured at runtime rather than build time.

@cjpearson cjpearson requested a review from danielroe as a code owner August 15, 2024 07:16
@cjpearson
Copy link
Contributor Author

I'm not sure why the test failed, it seems to work fine locally. I've rebased with main to see if that helps.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 63.21%. Comparing base (a1fc769) to head (02e8b72).
Report is 117 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
+ Coverage   63.20%   63.21%   +0.01%     
==========================================
  Files          79       79              
  Lines        3615     3616       +1     
  Branches      406      406              
==========================================
+ Hits         2285     2286       +1     
  Misses       1301     1301              
  Partials       29       29              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe merged commit 963c9c2 into nuxt:main Aug 29, 2024
1 check passed
@danielroe
Copy link
Member

Thank you ❀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing the runtimeConfig to provider getImage functions
3 participants