Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert <NuxtImg> to SFC #1435

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

DamianGlowala
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Converts <NuxtImg> to SFC with script setup for more familiar/user-friendly syntax.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 74.62687% with 34 lines in your changes missing coverage. Please review.

Project coverage is 62.24%. Comparing base (3104213) to head (082aa9e).
Report is 9 commits behind head on main.

Files Patch % Lines
src/runtime/components/NuxtImg.vue 73.22% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
- Coverage   62.26%   62.24%   -0.03%     
==========================================
  Files          79       79              
  Lines        3599     3597       -2     
  Branches      397      394       -3     
==========================================
- Hits         2241     2239       -2     
  Misses       1328     1328              
  Partials       30       30              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@DamianGlowala DamianGlowala self-assigned this Aug 26, 2024
@danielroe danielroe merged commit 52321bf into nuxt:main Aug 27, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants