Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weserv): map rotate operation to ro #1441

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(weserv): map rotate operation to ro #1441

merged 1 commit into from
Aug 27, 2024

Conversation

DamianGlowala
Copy link
Member

@DamianGlowala DamianGlowala commented Aug 27, 2024

πŸ”— Linked issue

resolves #1408

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Rotation operator should be mapped to ro instead of rot, as per docs.

@DamianGlowala DamianGlowala self-assigned this Aug 27, 2024
Copy link

Deploying nuxt-image with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: dc2fe8d
Status:Β βœ…Β  Deploy successful!
Preview URL: https://57c244f9.nuxt-image.pages.dev
Branch Preview URL: https://fix-weserv-rotate.nuxt-image.pages.dev

View logs

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 62.26%. Comparing base (3104213) to head (dc2fe8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1441   +/-   ##
=======================================
  Coverage   62.26%   62.26%           
=======================================
  Files          79       79           
  Lines        3599     3599           
  Branches      397      397           
=======================================
  Hits         2241     2241           
  Misses       1328     1328           
  Partials       30       30           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe merged commit c37d889 into main Aug 27, 2024
2 checks passed
@danielroe danielroe deleted the fix/weserv-rotate branch August 27, 2024 11:05
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weserv provider doesn't rotate
3 participants