Add excluded_search_path_prefixes setting - improves perf in WSL

[stuartleeks]

Allows filtering the paths used to search for commands
Can be useful to filter out /mnt/ in WSL for performance

Running in WSL with default config:

DEBUG: Total took: 0:00:10.213128

Running in WSL with excluded_search_path_prefixes = ['/mnt/'] in settings.py:

DEBUG: Total took: 0:00:00.617300

This provides an approach to solving #1036 without having to remove Windows paths from PATH (which breaks various WSL use-cases)

[stuartleeks]

Just checking back to see whether there is anything I can do to help make this easier to review? Thanks!

[swirle13]

What would it take to get this pulled in?

[scorphus]

Thanks for the valuable contribution and for a very complete patch, @stuartleeks! Much appreciated! 👍

Please, consider my suggestions below.

[stuartleeks]

Thanks for the review @scorphus! I've included your suggestions and rebased on latest master

However, I notice that the automated checks are failing on python 2.7 at what looks to be the install stage. I'm not sure how the changes made would have caused this and have just tested installing on 2.7.17 locally and it seemed to work fine (unit and functional tests pass locally on 2.7.17, too). If you have any pointers for investigating further that would be greatly appreciated!

[scorphus]

Glad you're still on it, @stuartleeks. Sorry for the delay.

I wonder why pip is installing decorator 5.x for Python 2.7. It should install 4.4.2 instead. Anyway, I didn't investigate too much into that issue. Instead came up with #1187 that forces decorator<5 for Python <= 2.7. Once 3.31 is released, this and other makeshifts will be removed.

I'll get #1187 merged soon. Then you're free to rebase on top of master again. Thanks in advance!

[stuartleeks]

Ok, cool. I'll rebase again once #1187 is merged and hopefully this will be ready to go 😁
Thanks!

[stuartleeks]

Rebased now that #1187 is merged and the tests are now passing - thanks @scorphus !

[swirle13]

can't wait to update with these changes implemented with 3.31. I can't believe me commenting here kicked off the attention this needed to finally get merged and now I don't have to worry about manually building these changes into every new release haha

[scorphus]

Thanks for the update, @stuartleeks! I'll be merging this shortly!

@mjohnson159 Thanks for commenting and bringing it to my attention. We really need to get 3.31 out, right!? It's been a long time since the last release. Would you be willing to help me confirming fixes for some other Windows-related issues? That would be super helpful!

[scorphus]

Thanks for contributing, @stuartleeks! ❤️