Add support for switch_lang for Korean. #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew_command instead of match.
ik1ne
changed the title
scorphus
requested changes
Oct 17, 2019
|
Done, I also changed |
scorphus
approved these changes
Oct 17, 2019
|
@nvbn This contribution has two authors. I'm wondering if we keep authorship in the commits or not. How should we proceed? Combine commits into one per author? Or merge them all into one? |
|
Looks good, thanks! |
|
@scorphus I thought that github can handle that, added everyone in the commit message just in case =) |
riley-martine
pushed a commit
to riley-martine/thefuck
that referenced
this pull request
Dec 7, 2023
* switch korean letters to english * revised according to recent changes * Fix typo in tests/test_switch_lang.py * Add a test case for coverage * Change: Moved decomposing logic which changes command.script to get_new_command instead of match. * Fix: changed unicode characters to unicode string for python2 compatibility. * Fix: Modified to change request. @ik1ne @yangkyeongmo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PR of #880 .