ci: fix action failures #309
Conversation
Run npm lint:fix to get a good baseline for further changes.
Fix the permission errors triggered by checkov CKV2_GHA_1 by giving the workflows only their required permissions.
Fix the errors about spelling reported by cspell.
stevenh
force-pushed
the
chore/fix-checks
branch
from
bb71849 to
3e8a835
Compare
Fix the permission on lib/index.js causing failure of npm run test:debug sh: 1: npm-groovy-lint: Permission denied
|
@stevenh I changed the settings of the repo, github action jobs should run without approval now :) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 93.06% 92.54% -0.53%
==========================================
Files 82 82
Lines 1991 2013 +22
==========================================
+ Hits 1853 1863 +10
- Misses 138 150 +12
☔ View full report in Codecov by Sentry. |
stevenh
force-pushed
the
chore/fix-checks
branch
2 times, most recently
from
e3b5a35 to
cb54f11
Compare
Switch debian from stretch image for openjdk 8 to buster as stretch is so old apt update fails even when pointed at archive.debian.org. Also switch to multi line run syntax to make it easier to see what is being run.
Switch to using actions/setup-node to simplify installation of node.
stevenh
force-pushed
the
chore/fix-checks
branch
3 times, most recently
from
265d30c to
55edcdb
Compare
Fix markdown lint issues flagged by megalinter ci.
stevenh
force-pushed
the
chore/fix-checks
branch
from
55edcdb to
15f529d
Compare
|
Don't worry about the auto commit failure, it's just because tou don't have the rights from a fork :) |
stevenh
force-pushed
the
chore/fix-checks
branch
2 times, most recently
from
a3525e3 to
70b375c
Compare
Yep, there seemed to be a way to do it but that requires contributors to make changes there end, so too high a barrier I'm now looking to skip it when a fork is detected. |
Skip creating a commit of lint changes for forks as permissions don't permit that without jumping through hoops.
Bump all actions to the latest versions to bring in all the related fixes.
stevenh
force-pushed
the
chore/fix-checks
branch
from
70b375c to
a9f3a85
Compare
Fix lint failures reported by lychee by correcting / removing broken links.
|
Ok so node 12 is really old and the major version bumps didn't go quite to plan. Might want to consider dropping support for node 12 in the future. |
Update all npm modules to address security issues flagged by grype linter and remove now unreferenced modules. This also includes a small fix to server kill flow to handle the error returned by newer versions of axios, as well as fix to the server itself to send the response before calling stopServer which should render the special case for terminated unneeded. No major version bumps we're applied to maintain compatibility with node 12.
stevenh
force-pushed
the
chore/fix-checks
branch
from
e0853dc to
a91d82b
Compare
Enable npm-groovy-lint debugging for tests on windows and mac to help identify the cause of the hangs.
|
@stevenh you can remove node 12 compat, good idea! |
Fix the handling of the CodeNarc process when it's not accessible via its web API. We now maintain a handle to the process so if we can't get a response to the initial ping requests we can still shut it down. In addition to this correctly handle the timeout in the error case.
Got it working for now, will do that later. |
Fix requests failing to talk to CodeNarc server due to Java preferring IPv4 port binding by default and vscode-groovy-lint on Windows resolving localhost to its IPv6 address. We now use an IPv4 agent for all requests.
Switch codecov from bash to github action as the bash script has been deprecated for some time.
Enable debugging on the workflows which are failing.
|
Oh wow, wasn't expecting that to just pass, still had lots of debug in there. I'll make sure I use a draft for work in progress |
Fix issues causing actions to report errors.