fix(cli): account for parse errors being of string type #444
+35
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- regex parse the incoming string message for its parts. Change the case to skip the check on unresolved class to "includes" instead of starts with
|
@joshzcold many thanks for your PR :) But I can't merge it while there are crashing test methods, please can you solve them then mention me again ? |
joshzcold
commented
Feb 21, 2025
|
@nvuillam now ready 👍 |
|
@joshzcold great ! :) |
nvuillam
approved these changes
Feb 22, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regex parse the incoming string message for its parts.
Change the case to skip the check on unresolved class to "includes" instead of starts with
Fixes
Proposed Changes