Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous instruction #704

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Remove superfluous instruction #704

merged 1 commit into from
Jul 24, 2020

Conversation

ibnesayeed
Copy link
Member

Close #703

@ibnesayeed ibnesayeed requested a review from machawk1 July 14, 2020 21:37
@codecov
Copy link

codecov bot commented Jul 14, 2020 •
edited
Loading

Codecov Report

Merging #704 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   29.24%   29.24%           
=======================================
  Files          10       10           
  Lines        1248     1248           
  Branches      185      185           
=======================================
  Hits          365      365           
  Misses        860      860           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9334ace...e890dd2. Read the comment docs.

@machawk1 machawk1 mentioned this pull request Jul 15, 2020
Closed
machawk1
machawk1 approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@machawk1 machawk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am convinced by the discussion in #703 that this addition instruction of using the external requirements file for installation so long as we report the requirements in setup.py.

@machawk1 machawk1 merged commit 0c1c690 into master Jul 24, 2020
@machawk1 machawk1 deleted the issue-703 branch July 24, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machawk1 machawk1 machawk1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove superfluous dependency install instruction in README
2 participants
@ibnesayeed @machawk1