Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes web UI text field to be of type url to enable supporting #725

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

machawk1
Copy link
Member

devices to show a more relevant keyboard.

Closes #724

devices to show a more relevant keyboard.

Closes #724
@machawk1 machawk1 requested a review from ibnesayeed January 12, 2021 19:11
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #725 (f92f15d) into master (c1392a2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #725   +/-   ##
=======================================
  Coverage   30.06%   30.06%           
=======================================
  Files          10       10           
  Lines        1264     1264           
  Branches      185      185           
=======================================
  Hits          380      380           
  Misses        861      861           
  Partials       23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1392a2...f92f15d. Read the comment docs.

Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machawk1 machawk1 merged commit b4cd463 into master Jan 13, 2021
@machawk1 machawk1 deleted the issue-724 branch January 13, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input type on web interface is of type "text" when it would be better set to "url"
2 participants