Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use latest (albeit alpha) ipfshttpclient, support go-ipfs 0.7.0 and 0.8.0 in testing #729

Merged
merged 2 commits into from
May 20, 2021

Conversation

machawk1
Copy link
Member

The prerelease of the dependency (on PyPI) fixes the version check issues that caused tests to fail.

Closes #716 and #726

@machawk1 machawk1 requested a review from ibnesayeed May 19, 2021 14:35
@machawk1 machawk1 changed the title Update to use latest (albeit alpha) pyipfsclient Update to use latest (albeit alpha) ipfshttpclient May 19, 2021
@machawk1 machawk1 changed the title Update to use latest (albeit alpha) ipfshttpclient Update to use latest (albeit alpha) ipfshttpclient, support go-ipfs 0.7.0 and 0.8.0 in testing May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #729 (73fb50d) into master (b4cd463) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   30.06%   30.06%           
=======================================
  Files          10       10           
  Lines        1264     1264           
  Branches      185      185           
=======================================
  Hits          380      380           
  Misses        861      861           
  Partials       23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4cd463...73fb50d. Read the comment docs.

@machawk1 machawk1 linked an issue May 19, 2021 that may be closed by this pull request
Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machawk1 machawk1 merged commit 609bbeb into master May 20, 2021
@machawk1 machawk1 deleted the issue-726 branch May 20, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to test with go-ipfs 0.8.0 Update to test with go-ipfs 0.7.0
2 participants