Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for TimeMap retrieval via replay endpoint #743

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

machawk1
Copy link
Member

Per @ibnesayeed at #742 (comment)

While a better approach might be to have unit tests for the functions, I believe this addition is a step in the right direction.

Relates to #180, too.

@machawk1 machawk1 requested a review from ibnesayeed August 23, 2021 20:29
Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machawk1 machawk1 merged commit f9784e0 into master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants