enhancement(AmountInput): standardize + i18n support #11002
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Betree
force-pushed
the
enhancement/amount-input-i18n
branch
from
bce8ba9 to
0876c98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve opencollective/opencollective#2954
Uses https://github.com/cchanxzy/react-currency-input-field seems for the amount input. Notable differences compared to our current amount input experience:
intlconfig to the input, and it takes care of formatting the number / ignoring unwanted charactersTo do:
JPY/ zero-decimals currencies (require fix: handle cases where decimalSeparator is empty cchanxzy/react-currency-input-field#385)