VCS fcov false support

[jordancarlin]

wsim supports passing --fcov when using VCS and the run_vcs script accepts the --fcov flag, but it does not do anything with the flag so functional coverage is not actually generated. The run_vcs script either needs to be updated to properly support fcov or this flag should be disabled. @davidharrishmc not sure which path you want to take with this one.

[davidharrishmc]

We aren’t using coverage in VCS yet. It’s probably more than an hour to figure out how to add functional and code coverage, so I think it’s best to just print an unsupported error for now.

…

On Dec 7, 2024, at 2:18 PM, Jordan Carlin ***@***.***> wrote: wsim supports passing --fcov when using VCS and the run_vcs script accepts the --fcov flag, but it does not do anything with the flag so functional coverage is not actually generated. The run_vcs script either needs to be updated to properly support fcov or this flag should be disabled. @davidharrishmc <https://github.com/davidharrishmc> not sure which path you want to take with this one. — Reply to this email directly, view it on GitHub <#1179>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR4AA346JTAOOAOL3FVWSLT2ENX3DAVCNFSM6AAAAABTGS3WRCVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4ZDIOBTGUZTKOA>. You are receiving this because you were mentioned.

[jordancarlin]

Code coverage is already set up. Just needed a quick fix that I pushed in #1177.

I'm making some changes to how fcov is handled by wsim in my next PR. I think with those changes it will be trivial to support it in VCS, but if that turns out not to be the case then I'll go ahead and have it print out an error instead of its current behavior of silently failing.

[davidharrishmc]

If it works easily, that’s great and some users will be glad to have it. Our code coverage depends on some TCL scripting to exclude uncoverable items. It’s amazing to me that VCS runs the Questa script unchanged. I’d think the vcover might need changing as well to merge all our coverage. David

…

On Dec 8, 2024, at 6:06 AM, Jordan Carlin ***@***.***> wrote: Code coverage is already set up. Just needed a quick fix that I pushed in #1177 <#1177>. I'm making some changes to how fcov is handled by wsim in my next PR. I think with those changes it will be trivial to support it in VCS, but if that turns out not to be the case then I'll go ahead and have it print out an error instead of its current behavior of silently failing. — Reply to this email directly, view it on GitHub <#1179 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR4AA33Q7GBLCSYEZGHGYXL2ERG45AVCNFSM6AAAAABTGS3WRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVHE4TMMJUHA>. You are receiving this because you were mentioned.

[jordancarlin]

I haven’t looked at the report in all that much detail yet. I suspect the exclusions aren’t working, but it is at least collecting coverage again instead of throwing a cryptic error message. On Sun, Dec 8, 2024 at 6:21 AM David Harris ***@***.***> wrote:

…

If it works easily, that’s great and some users will be glad to have it. Our code coverage depends on some TCL scripting to exclude uncoverable items. It’s amazing to me that VCS runs the Questa script unchanged. I’d think the vcover might need changing as well to merge all our coverage. David > On Dec 8, 2024, at 6:06 AM, Jordan Carlin ***@***.***> wrote: > > > Code coverage is already set up. Just needed a quick fix that I pushed in #1177 <#1177>. > > I'm making some changes to how fcov is handled by wsim in my next PR. I think with those changes it will be trivial to support it in VCS, but if that turns out not to be the case then I'll go ahead and have it print out an error instead of its current behavior of silently failing. > > — > Reply to this email directly, view it on GitHub < #1179 (comment)>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AR4AA33Q7GBLCSYEZGHGYXL2ERG45AVCNFSM6AAAAABTGS3WRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVHE4TMMJUHA>. > You are receiving this because you were mentioned. > — Reply to this email directly, view it on GitHub <#1179 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGCDBCVGTNA2XPOW2X6VGV32ERIYPAVCNFSM6AAAAABTGS3WRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRWGAZTMMRYGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>