Revert PR 719 #802
Merged
Revert PR 719 #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@porink0424 Could you review this PR? |
c-bata
commented
Feb 9, 2024
Comment on lines
-2
to
-4
| ignore = | ||
| E203 | ||
| W503 |
There was a problem hiding this comment.
We could introduce these options to align with Optuna's flake8 options. Let me address this in the following pull request.
https://github.com/optuna/optuna/blob/11dca397313eca84dd183e57351c33f33b05e4f6/setup.cfg#L2-L5
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #802 +/- ##
==========================================
- Coverage 69.81% 69.71% -0.11%
==========================================
Files 35 35
Lines 2369 2364 -5
==========================================
- Hits 1654 1648 -6
- Misses 715 716 +1 ☔ View full report in Codecov by Sentry. |
keisuke-umezawa
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Revert #719
What does this implement/fix? Explain your changes.
Revert #719 since we've found some issues on that changes.