Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update near cache to support synchronous listeners #98

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Update near cache to support synchronous listeners #98

merged 4 commits into from
Dec 5, 2024

Conversation

tmiddlet2666
Copy link
Member

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 3, 2024
rlubke
rlubke previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@rlubke rlubke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that one typo. Looks good.

rlubke
rlubke reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@rlubke rlubke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, don't forget to update isNearCacheEqual to account for the prune factor.

@tmiddlet2666 tmiddlet2666 requested a review from rlubke December 4, 2024 23:51
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tmiddlet2666 tmiddlet2666 merged commit a1f7a65 into main Dec 5, 2024
116 checks passed
@tmiddlet2666 tmiddlet2666 deleted the coh-31146 branch December 5, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlubke rlubke rlubke approved these changes

@thegridman thegridman Awaiting requested review from thegridman

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmiddlet2666 @rlubke