floor and ceil should return integers

[Eun]

See

• https://shopify.github.io/liquid/filters/floor/
• https://shopify.github.io/liquid/filters/ceil/

Checklist

• I have read the contribution guidelines.
• make test passes.
• make lint passes.
• New and changed code is covered by tests.
• Performance improvements include benchmarks.
• Changes match the documented (not just the implemented) behavior of Shopify.

[coveralls]

Coverage decreased (-39.6%) to 49.546% when pulling 5540947 on Eun:master into e0ae159 on osteele:master.

[osteele]

Thanks for your contribution!

What is the test case for this? filters/standard_filters.rb contains

	{`1.2 | ceil`, 2},
	{`2.0 | ceil`, 2},
	{`183.357 | ceil`, 184},
	{`"3.5" | ceil`, 4},

	{`1.2 | floor`, 1},
	{`2.0 | floor`, 2},
	{`183.357 | floor`, 183},

Is there another case where the current implementation behaves differently from the Ruby Liquid version? Can a test be made for this?

[Eun]

Yes we could improve the tests by checking the types as well.
I did not notice other type problems.

---

The actual requirement was something like this:

{% assign TotalPages = Pages | plus: 5 %}
{% for i in (1..MaxPage) %}

(it is not possible to loop until a float variable, so we need an integer) ({% assign TotalPages = Pages | plus: 5 | floor %}