Enhanced EventWatcher logs #5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
This reverts commit de3f112. Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
khanhtc1202,
ffjlabo and
Warashi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5558 +/- ##
==========================================
- Coverage 26.42% 26.41% -0.02%
==========================================
Files 465 465
Lines 49907 49938 +31
==========================================
Hits 13189 13189
- Misses 35663 35694 +31
Partials 1055 1055 ☔ View full report in Codecov by Sentry. |
Signed-off-by: t-kikuc <[email protected]>
ffjlabo
approved these changes
Feb 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
* Show push error log earlier than reporting Signed-off-by: t-kikuc <[email protected]> * Use WarnLog in retry Signed-off-by: t-kikuc <[email protected]> * clarify log messages Signed-off-by: t-kikuc <[email protected]> * clarify log messages Signed-off-by: t-kikuc <[email protected]> * add TestDoCalls for asserting counts Signed-off-by: t-kikuc <[email protected]> * add eventIDs in log Signed-off-by: t-kikuc <[email protected]> * enrich logs in updateValues Signed-off-by: t-kikuc <[email protected]> * nits Signed-off-by: t-kikuc <[email protected]> * Revert "add TestDoCalls for asserting counts" This reverts commit de3f112. Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
* Show push error log earlier than reporting Signed-off-by: t-kikuc <[email protected]> * Use WarnLog in retry Signed-off-by: t-kikuc <[email protected]> * clarify log messages Signed-off-by: t-kikuc <[email protected]> * clarify log messages Signed-off-by: t-kikuc <[email protected]> * add TestDoCalls for asserting counts Signed-off-by: t-kikuc <[email protected]> * add eventIDs in log Signed-off-by: t-kikuc <[email protected]> * enrich logs in updateValues Signed-off-by: t-kikuc <[email protected]> * nits Signed-off-by: t-kikuc <[email protected]> * Revert "add TestDoCalls for asserting counts" This reverts commit de3f112. Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
t-kikuc
added a commit
that referenced
this pull request
Feb 17, 2025
* Correct notification routing for `DEPLOYMENT_STARTED` (#5523) * Correct notification routing for `DEPLOYMENT_STARTED` Signed-off-by: Yuki Okushi <[email protected]> * Harden test case Signed-off-by: Yuki Okushi <[email protected]> --------- Signed-off-by: Yuki Okushi <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Sort results of plan-preview (#5540) * Sort results of plan-preview Signed-off-by: kj455 <[email protected]> * Ensure the order of list piped Signed-off-by: kj455 <[email protected]> * fix: lint Signed-off-by: kj455 <[email protected]> * fix: move sorting to pipectl Signed-off-by: kj455 <[email protected]> * fix: add testcase Signed-off-by: kj455 <[email protected]> * fix: dev docs Signed-off-by: kj455 <[email protected]> * add docs Signed-off-by: kj455 <[email protected]> --------- Signed-off-by: kj455 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Enhanced EventWatcher logs (#5558) * Show push error log earlier than reporting Signed-off-by: t-kikuc <[email protected]> * Use WarnLog in retry Signed-off-by: t-kikuc <[email protected]> * clarify log messages Signed-off-by: t-kikuc <[email protected]> * clarify log messages Signed-off-by: t-kikuc <[email protected]> * add TestDoCalls for asserting counts Signed-off-by: t-kikuc <[email protected]> * add eventIDs in log Signed-off-by: t-kikuc <[email protected]> * enrich logs in updateValues Signed-off-by: t-kikuc <[email protected]> * nits Signed-off-by: t-kikuc <[email protected]> * Revert "add TestDoCalls for asserting counts" This reverts commit de3f112. Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * update RELEASE to v0.50.2 with doc update (#5571) Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> --------- Signed-off-by: Yuki Okushi <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: kj455 <[email protected]> Signed-off-by: t-kikuc <[email protected]> Co-authored-by: Yuki Okushi <[email protected]> Co-authored-by: Ibuki Kaji <[email protected]> Co-authored-by: Tetsuya KIKUCHI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Mainly:
retry.Do()Why we need it:
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: