Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minimum pair validation for deploy targets in RPC #5591

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Feb 20, 2025

What this PR does:

as title

Why we need it:

We have to continue supporting application registration with a non-plugin-architectured piped.
Such a piped doesn't support deploy targets configuration, so we cannot validate that it must be present.

Which issue(s) this PR fixes:

Part of #5252

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…pplication requests

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.27%. Comparing base (acde5ae) to head (8d88062).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5591      +/-   ##
==========================================
- Coverage   26.28%   26.27%   -0.02%     
==========================================
  Files         470      470              
  Lines       50353    50353              
==========================================
- Hits        13234    13228       -6     
- Misses      36059    36065       +6     
  Partials     1060     1060              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi enabled auto-merge (squash) February 20, 2025 01:39
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

In the future, it might be better to create AddApplicationRequestV1 if the validation is complex.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit c4fbf0d into master Feb 20, 2025
17 of 18 checks passed
@Warashi Warashi deleted the remove-deploy-targets-by-plugin-validation branch February 20, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants