Update banner to mention MIT license #6111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
approved these changes
Mar 5, 2024
|
Is the source map affected on Debug builds now that the copyright notice is longer? 😅 |
|
I would prefer to actually insert the full license, because if the engine is used in the context of a website. There is no source tree. |
|
@lucaheft If it's good enough for React, isn't it sufficient here? https://unpkg.com/[email protected]/umd/react.production.min.js |
|
Welp i guess so. I'm no legal expert, but if they are doing it like that it's propably alright. Thanks for adding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update built engine banner to explicitly call out that the build is under an MIT license.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.