Small gsplat shader update #7186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Dec 9, 2024
mvaligursky
reviewed
Dec 9, 2024
| vec4 splat_proj = matrix_projection * splat_cam; | ||
|
|
||
| // ensure gaussians are not clipped by camera near and far | ||
| splat_proj.z = clamp(splat_proj.z, -abs(splat_proj.w), abs(splat_proj.w)); |
There was a problem hiding this comment.
it feels incorrect to not clip them by the far camera.
mvaligursky
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default gsplat shader to refrain from clipping gaussians by the near and far camera clipping planes. Depth values are clamped instead.