Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Allow sphere maps to work when an envAtlas is set #7201

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[FIX] Allow sphere maps to work when an envAtlas is set #7201

merged 1 commit into from
Dec 16, 2024

Conversation

willeastcott
Copy link
Contributor

Fixes #5253
Fixes #5364

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott added bug area: graphics Graphics related issue labels Dec 15, 2024
@willeastcott willeastcott self-assigned this Dec 15, 2024
mvaligursky
mvaligursky reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels bit strange that when the sphereMap is set, it goes to the else branch where it seems to use constant ambient?

@willeastcott
Copy link
Contributor Author

Feels bit strange that when the sphereMap is set, it goes to the else branch where it seems to use constant ambient?

Sphere maps basically override/ignore the env atlas. So it's not that weird.

@willeastcott willeastcott merged commit 2b4fdec into main Dec 16, 2024
8 checks passed
@willeastcott willeastcott deleted the sphere-map-envatlas branch December 16, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky left review comments

@slimbuck slimbuck slimbuck approved these changes

Assignees

@willeastcott willeastcott

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
3 participants
@willeastcott @slimbuck @mvaligursky