Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CameraComponentSystem onUpdate handler #7208

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Remove CameraComponentSystem onUpdate handler #7208

merged 3 commits into from
Dec 18, 2024

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Dec 18, 2024 •
edited
Loading

  • The onUpdate handler is empty and can be safely removed.
  • It's not overridden or utilized in any way by the Editor.
  • Correctly off the prerender event in ComponentSystem#destroy.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott self-assigned this Dec 18, 2024
@willeastcott willeastcott merged commit 680d0d5 into main Dec 18, 2024
8 checks passed
@willeastcott willeastcott deleted the rm-cam-onupdate branch December 18, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@willeastcott willeastcott

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willeastcott @slimbuck @mvaligursky