Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Deprecate WebGL1 based texture sampling names with _EXT #7221

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Dec 20, 2024

Marked as [BREAKING] as if the user code uses these macros in the shaders, they need to be renamed (EXT letters removed)

  • the deprecated texture sampling are no longer an extension, but are core functionality, so rename the marcos
  • keep old macros in a deprecated format to get useful shader compilation errors

See red lines with the old naming containing EXT, and green lines bellow with new names
Screenshot 2024-12-20 at 12 07 06

@mvaligursky mvaligursky self-assigned this Dec 20, 2024
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Dec 20, 2024
@mvaligursky mvaligursky changed the title Deprecate WebGL1 based texture sampling names with _EXT [BREAKING] Deprecate WebGL1 based texture sampling names with _EXT Dec 20, 2024
@mvaligursky mvaligursky requested a review from a team December 20, 2024 12:08
@mvaligursky mvaligursky merged commit f846867 into main Dec 20, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-texture-ext branch December 20, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants