Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove PVRT texture formats with sRGB encoding as not supported on any platform #7256

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 9, 2025

PTRTC textures are stored in non sRGB equivalent, and StandardMaterial generated shaders automatically convert sRGB values to linear by shader code.

Note that this means PTRTC cannot be used in shaders that do not handle automatic conversion (for example Particle System textures).

@mvaligursky mvaligursky self-assigned this Jan 9, 2025
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Jan 9, 2025
@mvaligursky mvaligursky requested a review from a team January 9, 2025 16:49
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting stuff is so satisfying!

@mvaligursky
Copy link
Contributor Author

Deleting stuff is so satisfying!

Less so considering I only added those 2 months ago :)

@mvaligursky mvaligursky merged commit a7b8ae5 into main Jan 10, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-remove-srgb-pvrt branch January 10, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants