Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose PLY load progress #7259

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

slimbuck
Copy link
Member

This PR addresses the issue in https://forum.playcanvas.com/t/gsplat-loading-progress/38451

The PLY loader is updated to fire progress events during loading.

Notes:

  • in practise the content-length response header is not always correct:
    • it can be missing from the response header entirely if server doesn't provide it, and also in some cors situations
    • the size represents the gzipped size of the resource, while the streaming byte sizes are uncompressed bytes (i.e. readBytes can be larger than totalBytes)

@slimbuck slimbuck merged commit 5877a21 into playcanvas:main Jan 10, 2025
7 checks passed
@slimbuck slimbuck deleted the ply-progress-dev branch January 10, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants