Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShaderMaterial generator provides GAMMA and TONEMAPPING defines to VS #7280

Merged
merged 1 commit into from
Jan 14, 2025
Merged

ShaderMaterial generator provides GAMMA and TONEMAPPING defines to VS #7280

merged 1 commit into from
Jan 14, 2025

Conversation

mvaligursky
Copy link
Contributor

  • in addition to fragment shader, those are added to vertex shader, allowing users to execute tonemapping / gamma correction per vertex if more performant (needed for gsplats)

@mvaligursky mvaligursky requested a review from a team January 14, 2025 14:57
@mvaligursky mvaligursky self-assigned this Jan 14, 2025
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Jan 14, 2025
@mvaligursky mvaligursky merged commit 0188c57 into main Jan 14, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-shader-material-defs branch January 14, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck