Examples build rework #7314
Merged
Examples build rework #7314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Jan 28, 2025
kpal81xd
added a commit
that referenced
this pull request
Jan 28, 2025
* Converted build examples script into rollup build step * Refactored rollup * minor refactor * Added share to rollup build * Removed injecting nodeEnv into rollup plugin * Cleaned up scripts * Fixed lint issue * Removed comment (not required) * Removed not await in loop * Fixed lint issue * Moved example template to templates folder
kungfooman
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR converts the old build system which generated all examples manually inside a rollup plugin to using rollup itself to watch and rebuild each example independently. This should also minimise the hot reload latency that accumulates over time.
Overview