Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes canvas to optional dependency #7358

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Changes canvas to optional dependency #7358

merged 2 commits into from
Feb 18, 2025

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Feb 18, 2025

This PR converts the canvas peer dependency of JSDom to an optional dependency causing it fail silently when cannot be installed (in this case building on Vercel)

NOTE: Canvas or JSDom are only used in tests and not used on Vercel

@kpal81xd kpal81xd changed the title [TESTING] CI Changes canvas to optional dependency Feb 18, 2025
@kpal81xd kpal81xd self-assigned this Feb 18, 2025
@kpal81xd kpal81xd requested a review from a team February 18, 2025 12:29
@kpal81xd kpal81xd merged commit 375ec79 into main Feb 18, 2025
7 checks passed
@kpal81xd kpal81xd deleted the ci branch February 18, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants