🐛 add missing useEffect dependency to dcc.Loading component #2956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing dependency to the
useEffect
in the dcc.Loading component. This fixes a bug where it is possible for the loading spinner to be left enabled, even though loading has finished.Fixes https://github.com/plotly/notebook-to-app/issues/1674
Note: I haven't been able to write a integration test that covers this code change precisely. The bug does not normally make an appearance - it's only in rare React race conditions that it is possible to get the "infinite loading bars".
@gvwilson since this affects internal projects, I'd love to get your team's eyes on this so we could maybe do a patch release?
Contributor Checklist
optionals
CHANGELOG.md