Added missing fields to server name for ping responses #1114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This data is used to send back responses when a client pings the server, to show the server in the server list. However, there were 3 fields missing that vanilla MCPE sends that PocketMine-MP was not:
-1
, since with multiple worlds, which seed do you pick?This pull request will also provide a quick way to identify a PocketMine-MP server based on its ping response.
There are some unconfirmed bugs with this such as servers appearing in the wrong place in the server list if the list contains servers which do not include these extra fields. Please test and review.
Changes
API changes
Server::getGamemodeName(int $gamemode)
Behavioural changes