-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve font stack on Windows #1573
Conversation
🦋 Changeset detectedLatest commit: a412258 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Here the output for this PR with the updated font-family: -apple-system,BlinkMacSystemFont,"Segoe UI Variable Text","Segoe UI","Meiryo",system-ui,ui-sans-serif,Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji"; It can be used to test in DevTools. |
Hi @simurai .
|
@hiloki long time no talk. 😃 Yeah, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇 🙇
Co-authored-by: Jon Rohan <[email protected]>
Co-authored-by: Jon Rohan <[email protected]>
Warning: This CSS change has affected non-Japanese repository. |
@NightFurySL2001 Thanks for reporting. Hmmm.. It seems pretty hard to find the right font stack that works great for everyone. We might need to test it in a more isolated way first. So #1592 reverts all the font changes. @448jp @hiloki By also reverting #1529, the
that was in use 3 weeks ago. |
This is a follow up to #1529 and further improves the font stack on Windows:
Segoe UI Variable
->Segoe UI Variable Text
.Meiryo
beforesystem-ui
.Meiryo
instead ofYu Gothic UI
and should improve font rendering, especially for Japanese.Yu Gothic
was used. But with great feedback from @448jp and @hiloki Improve font stack on Windows #1573 (comment) it seemsMeiryo
is the better default.This came up in a private Slack convo