Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve font stack on Windows #1573

Merged
merged 8 commits into from
Sep 7, 2021
Merged

Improve font stack on Windows #1573

merged 8 commits into from
Sep 7, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Sep 7, 2021

This is a follow up to #1529 and further improves the font stack on Windows:

  • Segoe UI Variable -> Segoe UI Variable Text.
    • "Segoe UI Variable Text" seems to be the better option for a lot of text (markdown). In the future we might can consider having a UI and a "text" font stack.
  • Add Meiryo before system-ui.

This came up in a private Slack convo

@simurai simurai requested a review from vdepizzol September 7, 2021 02:34
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2021

🦋 Changeset detected

Latest commit: a412258

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simurai
Copy link
Contributor Author

simurai commented Sep 7, 2021

Here the output for this PR with the updated font-family:

font-family: -apple-system,BlinkMacSystemFont,"Segoe UI Variable Text","Segoe UI","Meiryo",system-ui,ui-sans-serif,Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";

It can be used to test in DevTools.

@hiloki
Copy link

hiloki commented Sep 7, 2021

Hi @simurai .

Yu Gothic is too skinny and low legibility.
Yu Gothic Medium is a little better.
[IMO] Meiryo is much better.

"Yu Gothic" "Yu Gothic Medium” "Meiryo"
YuGothic YuGothicMedium Meiryo

@simurai
Copy link
Contributor Author

simurai commented Sep 7, 2021

Meiryo is much better.

@hiloki long time no talk. 😃 Yeah, Meiryo does indeed look more readable. Let's try that. 👍

@simurai simurai marked this pull request as ready for review September 7, 2021 08:16
@simurai simurai requested a review from a team as a code owner September 7, 2021 08:16
@simurai simurai requested a review from jonrohan September 7, 2021 08:16
Copy link
Contributor

@vdepizzol vdepizzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 🙇

@simurai simurai merged commit 386dfa0 into main Sep 7, 2021
@simurai simurai deleted the improve-font-stack branch September 7, 2021 23:42
This was referenced Sep 7, 2021
@simurai
Copy link
Contributor Author

simurai commented Sep 13, 2021

@448jp @hiloki Ok, Meiryo should now be used on github.com

Screen Shot 2021-09-13 at 10 41 53

Let me know if you see something weird. And thanks again for the feedback. 🙇

@hiloki
Copy link

hiloki commented Sep 13, 2021

@simurai

LGTM

@NightFurySL2001
Copy link

Warning: This CSS change has affected non-Japanese repository.

@NightFurySL2001
Copy link

@simurai Please take a look on #1589.

@simurai
Copy link
Contributor Author

simurai commented Sep 14, 2021

Warning: This CSS change has affected non-Japanese repository.
Please take a look on #1589.

@NightFurySL2001 Thanks for reporting. Hmmm.. It seems pretty hard to find the right font stack that works great for everyone. We might need to test it in a more isolated way first. So #1592 reverts all the font changes.

@448jp @hiloki By also reverting #1529, the ui-system is gone too. So it will be back to

-apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"

that was in use 3 weeks ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants