Prepare main to hold code for next major version #1599
Conversation
Conflicts: README.md
* Rename and move color mode variables out of base package * Create mighty-goats-teach.md * Add test to make sure support is never more than 0 * Update mighty-goats-teach.md * Update mighty-goats-teach.md
* Moving color modes to their own bundle * Create new-beers-peel.md
…lace. (#1541) * Removing the rem() mixin and usages. Placing the computed values in place. * Create flat-shirts-lay.md
* Remove break-word from utilities * Create twelve-fireants-shave.md
Conflicts: src/base/modes.scss
jonrohan
requested review from
tobiasahlin and
simurai
and removed request for
tobiasahlin
🦋 Changeset detectedLatest commit: f572fe6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
I assume all the changes are coming from next_major. Looks good to me. Not sure when exactly we want to merge this. I guess we could wait for:
- Next major of
primer/primitives(without V1 variables) - Remove deprecated utilities
But that could also be done in 19.0.0 if really needed.
I also wonder what would've happened if we merged #1402. Would it automatically merge next_major into main and kick off a new 18.0.0 release?
Looks like it would ship
I don't think we need to wait, we'd merge this in and it'd start building the next version. As long as we're sure there's not going to be a minor or patch release between now and when we ship, it should be fine |
|
😬 🤞🏻 |
|
ok, this is it. Yep, no more minor or patch releases. |
This is my first time moving
next_majorinto main. I believe all we need to do is merge this pr into main, deleting thepre.jsonfile. This will start a new Release PR that will be18.0.0. Then when that is merged in we'll be at 18./cc @primer/css-reviewers