Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Group fixes #601

Merged
merged 6 commits into from
Nov 15, 2018
Merged

Button Group fixes #601

merged 6 commits into from
Nov 15, 2018

Conversation

shawnbot
Copy link
Contributor

This PR refactors our button group (BtnGroup class) component to:

  • Use Primer SCSS variables instead of static px values
  • Use display: inline-flex instead of display: inline-block + floats
  • Add z-index: 1 to active (.selected, :focus, :active) button group items
  • Replace hard-coded Storybook stories with those generated from the Markdown docs (previously, button groups weren't even present in Storybook!)

Fixes #600

@shawnbot shawnbot mentioned this pull request Nov 15, 2018
19 tasks
Copy link
Contributor

@emilybrick emilybrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the styling/css lgtm

@shawnbot shawnbot merged commit 358b8b6 into release-10.10.0 Nov 15, 2018
@shawnbot shawnbot deleted the button-stories branch November 15, 2018 22:54
@shawnbot shawnbot restored the button-stories branch November 19, 2018 21:57
@shawnbot shawnbot deleted the button-stories branch November 19, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants