-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite docs with Doctocat #851
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-doctocat.primer.now.sh |
... so it doesn't accidentally get published
... because we're not using Octicon components in live code examples
I spent most of yesterday trying to fix this bug. Turns out there is no straightforward fix. After discussing with @emplums, I think it's okay if we move forward with this pull without fixing this since it only affects macOS Safari users with a viewport of <1000px. I filed an issue for this bug on the primer/dococat repo (primer/doctocat#56) and react-focus-lock repo (theKashey/react-focus-lock#79). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge amount of great work and after clicking around on the site it seems to do everything at least as well (if not better) than our existing site. Search works great. Prefetching seems to be working nicely and page transitions are practically non-existent. And it all looks really good, down to the improved syntax highlighting. I'm sure we'll find issues, but with Doctocat in place I think they'll be a lot easier to fix than they were before. Kudos, @colebemis! 👏
This pull request refactors the Primer CSS documentation site to use Doctocat. The new site has feature parity with the old site (primer.style/css).
TODO