Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SelectPanel] Fix experimental SelectPanel anchoring behavior #5593

Merged
merged 13 commits into from
Jan 30, 2025
Merged

[SelectPanel] Fix experimental SelectPanel anchoring behavior #5593

merged 13 commits into from
Jan 30, 2025

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Jan 24, 2025 •
edited
Loading

Closes #

Changelog

New

Changed

The experimental SelectPanel component draws itself off the screen in certain scenarios, i.e. when the anchor element is on the right-hand side of the viewport.

Before:

Alt: a video of a SelectPanel story demonstrating how, when opened, the panel causes the viewport to grow off the screen.

before.mov

After:

Alt: a video of a SelectPanel story demonstrating that the panel now re-orients itself into the available space as expected.

after.mov

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Storybook)
- [ ] Changes are SSR compatible

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 09352a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5593 January 24, 2025 21:24 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.56 KB (0%)
packages/react/dist/browser.umd.js 104.89 KB (0%)

@camertron camertron force-pushed the fix_select_panel2_anchoring branch from 8ce738b to 916b988 Compare January 24, 2025 22:20
@github-actions github-actions bot temporarily deployed to storybook-preview-5593 January 24, 2025 22:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5593 January 27, 2025 17:51 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/359441

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 27, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5593 January 28, 2025 18:55 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5593 January 28, 2025 23:28 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jan 28, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@camertron camertron marked this pull request as ready for review January 29, 2025 17:47
@camertron camertron requested a review from a team as a code owner January 29, 2025 17:47
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

francinelucca
francinelucca approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! some non-blocking suggestions

@camertron camertron added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 2b05aad Jan 30, 2025
44 checks passed
@camertron camertron deleted the fix_select_panel2_anchoring branch January 30, 2025 18:18
@primer primer bot mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camertron @francinelucca