Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(SelectPanel): Set border-top-color on selectpanel footer #5712

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

jonrohan
Copy link
Member

@langermank noticed an issue with the selectpanel footer that had a dark line
image

Changelog

New

Changed

Set border-top-color for SelectPanel footer

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner February 19, 2025 22:44
@jonrohan jonrohan requested a review from TylerJDev February 19, 2025 22:44
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: fbcd773

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan requested a review from langermank February 19, 2025 22:44
@github-actions github-actions bot added the staff Author is a staff member label Feb 19, 2025
Copy link
Contributor

Uh oh! @jonrohan, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 2

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 19, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

Copy link
Contributor

github-actions bot commented Feb 19, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.74 KB (0%)
packages/react/dist/browser.umd.js 106.06 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5712 February 19, 2025 22:48 Abandoned
@jonrohan jonrohan enabled auto-merge February 19, 2025 22:57
@jonrohan jonrohan added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2025
@joshblack joshblack added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 22508b7 Feb 19, 2025
44 checks passed
@joshblack joshblack deleted the set_border_properly_on_selectpanel_footer branch February 19, 2025 23:23
@primer primer bot mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants