Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint issues in GeometryBuilder.js #7530

Open
wants to merge 1 commit into
base: dev-2.0
Choose a base branch
from

Conversation

HarshitaKatariya
Copy link

Resolves: #7519

Changes:

Fixed stroke vertices inheriting per-vertex properties like len by ensuring these properties are copied over when drawing strokes.
Added len property support for stroke vertices and updated geometry handling to properly apply these properties.
Fixed ESLint issues in GeometryBuilder.js by resolving indentation and trailing space errors.

PR Checklist:
npm run lint passes
[Inline reference] is included / updated
[Unit tests] are included / updated

@davepagurek
Copy link
Contributor

Hi @HarshitaKatariya, this bug is on the dev-2.0 branch, not the main branch, as vertexProperty does not exist in p5 1.x on main.

I think to address this, we will need to duplicate user vertex properties similarly to how we duplicate per-vertex stroke colors in p5.Geometry.js.

@HarshitaKatariya
Copy link
Author

Hi @davepagurek,

Thanks for the clarification! I'll update my PR to ensure user vertex properties are duplicated in a similar way to per-vertex stroke colors in p5.Geometry.js. I'll push the changes soon.

@HarshitaKatariya HarshitaKatariya changed the base branch from main to dev-2.0 February 6, 2025 23:46
@HarshitaKatariya HarshitaKatariya force-pushed the fix-stroke-vertex-properties branch from f5a864b to 9dfd54f Compare February 7, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[p5.js 2.0 Beta Bug Report]: vertexProperty() breaks if drawing with strokes
2 participants