Modify Agent to reduce frequency of Pods getting UnexpectedAdmissionError
#556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously we were clearing device usage slots when a node tries to reallocate it. We did this for fairness reasons, but it meant denying kubelet as the source of truth and irritating
UnexpectedAdmissionError
s. Furthermore, fairness of reallocating slots should already be ensured bySlotReconcilliation
, which be clearing unused slots more immediately, reducing the frequency of this scenario. Also, for local unshared devices, there is no reason to free the device up for other nodes.fixes #450
@bfjelds and @romoh would be great to get quick eyes on this small but significant change.
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)