Skip to content

Commit

Permalink
Remove outdated comments from descriptor.proto
Browse files Browse the repository at this point in the history
The `retention` and `target` options have been functional for a long time, so
we can delete these stale comments saying that they do not work yet.

PiperOrigin-RevId: 673401292
  • Loading branch information
acozzette authored and copybara-github committed Sep 11, 2024
1 parent ef17dab commit 5a68ddd
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/google/protobuf/descriptor.proto
Original file line number Diff line number Diff line change
Expand Up @@ -732,8 +732,6 @@ message FieldOptions {
optional bool debug_redact = 16 [default = false];

// If set to RETENTION_SOURCE, the option will be omitted from the binary.
// Note: as of January 2023, support for this is in progress and does not yet
// have an effect (b/264593489).
enum OptionRetention {
RETENTION_UNKNOWN = 0;
RETENTION_RUNTIME = 1;
Expand All @@ -744,8 +742,7 @@ message FieldOptions {

// This indicates the types of entities that the field may apply to when used
// as an option. If it is unset, then the field may be freely used as an
// option on any kind of entity. Note: as of January 2023, support for this is
// in progress and does not yet have an effect (b/264593489).
// option on any kind of entity.
enum OptionTargetType {
TARGET_TYPE_UNKNOWN = 0;
TARGET_TYPE_FILE = 1;
Expand Down

0 comments on commit 5a68ddd

Please sign in to comment.